Skip to content

fix(ci): update unstable release file path in CI scripts #3737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2024
Merged

fix(ci): update unstable release file path in CI scripts #3737

merged 1 commit into from
Jun 3, 2024

Conversation

5d
Copy link
Contributor

@5d 5d commented Jun 3, 2024 •
edited
Loading

Issue #

Description

During refactoring #3666 , we've moved file AmplifyAWSServiceConfiguration.swift from AmplifyPluginsCore to new package InternalAmplifyCredential. The new path for this file should be AmplifyPlugins/Core/AmplifyCredentials/AmplifyAWSServiceConfiguration.swift.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d requested a review from a team as a code owner June 3, 2024 22:22
@codecov Codecov
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.43%. Comparing base (108afe9) to head (4c3bd48).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3737   +/-   ##
=======================================
  Coverage   68.42%   68.43%           
=======================================
  Files        1079     1079           
  Lines       37556    37556           
=======================================
+ Hits        25699    25701    +2     
+ Misses      11857    11855    -2
Flag Coverage Δ
API_plugin_unit_test 68.97% <ø> (ø)
AWSPluginsCore 68.56% <ø> (ø)
Amplify 47.65% <ø> (-0.04%) ⬇️
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.37% <ø> (+0.03%) ⬆️
DataStore_plugin_unit_test 81.20% <ø> (ø)
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 62.87% <ø> (ø)
Predictions_plugin_unit_test 37.32% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.75% <ø> (ø)
unit_tests 68.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@5d 5d merged commit 1e70d09 into main Jun 3, 2024
79 checks passed
@5d 5d deleted the 5d/fix-unstable-release branch June 3, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisabhash thisisabhash thisisabhash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@5d @thisisabhash